Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add movement compensation #747

Merged
merged 10 commits into from
Jun 28, 2023
Merged

ENH: Add movement compensation #747

merged 10 commits into from
Jun 28, 2023

Conversation

larsoner
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)

Adds basic movement compensation capability. Part of #574, which I've fleshed out into additional steps

The if run == runs[0]: conditional in _get_raw_paths that makes it add noise and rest runs really makes the logic here convoluted. In my next PR I'll try to split that out entirely so that it's cleaner. I thought about doing it here but I think it would make it harder to review, and it'll be nice to have the ds004229-with-MC case in place already.

@larsoner
Copy link
Member Author

The code here is ready for review. Something is funky with the actual movecomp that I'm still investigating but hopefully it'll be a small fix that I can put on top of what's here already:

So @hoechenberger feel free to review and conditionally approve if you're happy with the code changes in principle, then I'll fix whatever is messing up the data and merge

@larsoner
Copy link
Member Author

Okay this finally works, here is the report (which is much better than main where the ERF just shows an artifact!):

Ready for review/merge from my end.

@larsoner
Copy link
Member Author

Approved so I'll merge and keep moving!

@larsoner larsoner merged commit 941c387 into mne-tools:main Jun 28, 2023
46 checks passed
@larsoner larsoner deleted the movecomp branch June 28, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants