-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add movement compensation #747
Conversation
The code here is ready for review. Something is funky with the actual movecomp that I'm still investigating but hopefully it'll be a small fix that I can put on top of what's here already: So @hoechenberger feel free to review and conditionally approve if you're happy with the code changes in principle, then I'll fix whatever is messing up the data and merge |
Okay this finally works, here is the report (which is much better than Ready for review/merge from my end. |
Approved so I'll merge and keep moving! |
Before merging …
docs/source/changes.md
)Adds basic movement compensation capability. Part of #574, which I've fleshed out into additional steps
The
if run == runs[0]:
conditional in_get_raw_paths
that makes it addnoise
andrest
runs really makes the logic here convoluted. In my next PR I'll try to split that out entirely so that it's cleaner. I thought about doing it here but I think it would make it harder to review, and it'll be nice to have theds004229
-with-MC case in place already.