Add "picard-extended_infomax" ICA algorithm #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
force-pushed
the
picard-ext-infomax
branch
from
dda6995
to
7df474b
Compare
hoechenberger
force-pushed
the
picard-ext-infomax
branch
from
7df474b
to
a811ac0
Compare
hoechenberger
changed the title
… into picard-ext-infomax
|
@agramfort Do you have any objections here? I would assume that you'd rather like to see a config option that allows to pass arbitrary kwargs to the ICA method, right? :) But I believe this approach here makes things easier for most users… |
larsoner
approved these changes
Oct 31, 2023
|
I'm just going to go ahead and merge; if you disagree, @agramfort, we can later revert, no problem! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed extended Infomax-based ICA decomposition, but wanted to use Picard for that. This PR adds
"picard-extended_infomax"to the list of supportedica_algorithmsBefore merging …
docs/source/changes.md)