Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Test result caching #836

Merged
merged 13 commits into from
Jan 24, 2024
Merged

MAINT: Test result caching #836

merged 13 commits into from
Jan 24, 2024

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jan 24, 2024

Before merging …

  • Changelog has been updated (docs/source/changes.md)

Closes #814

Let's see if we can replicate the issue! EDIT: Spoiler alert, we cannot.

@larsoner
Copy link
Member Author

@hoechenberger this appears headed for green. I was unable to replicate the caching issue on macOS, both datasets tested here appear to process in < 15s the second time. Ready for review/merge from my end. Happy to adjust CI requirements if you're happy (I folded the Style check into the doc consistency one since the only step we really needed there now was codespell, and knew we'd be adjusting requirements here anyway!)

@hoechenberger
Copy link
Member

Thanks! I also realized I cannot reliably reproduce on macOS. Sometimes the problem occurs and sometimes it doesn't. I usually work inside of a OneDrive folder, maybe this has implications...

@larsoner
Copy link
Member Author

I usually work inside of a OneDrive folder, maybe this has implications...

It seems like it could for mtime but for hash it would be weird. It really seems like the file hash shouldn't change!

@hoechenberger
Copy link
Member

Let's just go ahead here and I'll report back sometime in the future if I run into this issue again :)

@larsoner larsoner enabled auto-merge (squash) January 24, 2024 17:51
@larsoner larsoner merged commit 742e27e into mne-tools:main Jan 24, 2024
49 of 50 checks passed
@larsoner larsoner deleted the rerun branch January 24, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching seems not to be working on macOS
2 participants