-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image_kwargs to report #859
Conversation
…template into add_image_kwargs
for more information, see https://pre-commit.ci
…template into add_image_kwargs
Not sure what to do about the tests. The doc consistency I don't understand and the ubuntu-latest seems to be using the latest stable mne where the changes in report.add_epochs are not yet included? |
Also, it turns out that in order to use the rejection criteria from my config, I had to deal with the different scaling between rejection and plotting commands:
|
For the consistency we should merge #863 first probably, it should fix things for you I think We should maintain compat with latest MNE stable, so you'll need to |
…template into add_image_kwargs merge pr for automatic doc of config steps
for more information, see https://pre-commit.ci
…template into add_image_kwargs could not push without merging
for more information, see https://pre-commit.ci
…template into add_image_kwargs again
I think I need some help here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SophieHerbst pushed a few commits to DRY (don't repeat yourself) the code a bit, and also test that the option works -- locally the report seems to reflect reject
:
Can you look and make sure you're still happy?
Thank you @larsoner I ran it again on my data and I am very happy with it now. |
Thanks @SophieHerbst and @larsoner!!! |
Responds to issue #848
Now that mne has been updated, we can pass image_kwargs to report.add_epochs.
It works when I set the limits to the rejection limits in the config, but I cannot get it right when setting image_kwargs to None as per default.