Enable stricter linting #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid conflict with built-in typing module.
larsoner
reviewed
Mar 3, 2024
mne_bids_pipeline/_config.py
Outdated
|
|
||
| from annotated_types import Ge, Interval, Len | ||
| from mne import Covariance | ||
| from mne_bids import BIDSPath | ||
|
|
||
| from mne_bids_pipeline.typing import ( | ||
| from mne_bids_pipeline._types import ( |
There was a problem hiding this comment.
Speaking of public vs private, this one was meant to be public like numpy.typing because people might want to annotate with some of our types like ArbitraryContrast
There was a problem hiding this comment.
Like from mne_bids_pipeline.typing import ArbitraryContrast or similar
There was a problem hiding this comment.
I will revisit this tomrrow
There was a problem hiding this comment.
@larsoner I have reverted this change
This reverts commit 23069a5.
hoechenberger
changed the title
typing module
|
Thanks @hoechenberger ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)