MAINT: Check that all options are used #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
commented
Mar 14, 2024
| f"{where} cannot handle call {keyword.value.func.id=} " | ||
| f"for {key}" | ||
| ) | ||
| # Get the source and regex for config values |
There was a problem hiding this comment.
This file is copy-paste then refactored to have constants at the top, plus added regex for finding config. stuff in functions like _bids_kwargs and get_runs etc.
|
very nice! |
hoechenberger
approved these changes
Mar 14, 2024
🫣😅 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)Follow-up to #888:
study_namewhich we don't use anywhere (even though it's our first listed config option!)