Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate API for computing connectivity from Epochs vs Numpy Array #65

Open
adam2392 opened this issue Jan 4, 2022 · 0 comments
Open

Comments

@adam2392
Copy link
Member

adam2392 commented Jan 4, 2022

Describe the problem

Many of the Connectivity functions have a long list of parameters that are used if the input data is not Epochs. However, if the input is Epochs, then a lot of this can be trimmed.

Describe your solution

Similar to how mne-python has a function to compute tfr_wavelets from both Raw and numpy arrays, we should also have a function to compute on arrays vs MNE native data structures. This will then simplify how the user will call the underlying functions and also greatly simplify the implementation of the API for any function using Epochs.

cc: @drammock @larsoner

See for example: https://mne.tools/stable/generated/mne.time_frequency.tfr_morlet.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant