Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly expose Coregistration instance from CoregistrationUI #10255

Merged
merged 3 commits into from Jan 26, 2022

Conversation

hoechenberger
Copy link
Member

This exposes Coregistration via CoregistrationUI.coreg

Closes #10227

This exposes Coregistration via CoregistrationUI.coreg

Fixes mne-tools#10227
mne/gui/_coreg.py Outdated Show resolved Hide resolved
@hoechenberger hoechenberger requested review from larsoner and GuillaumeFavelier and removed request for larsoner January 26, 2022 16:39
@hoechenberger hoechenberger marked this pull request as ready for review January 26, 2022 16:39
@hoechenberger
Copy link
Member Author

hoechenberger commented Jan 26, 2022

(I'm having trouble with the doc build locally, so I will need to see whether Circle comes back green here. Otherwise this is good to go from my end)

@hoechenberger
Copy link
Member Author

hoechenberger commented Jan 26, 2022

CIs are having issues with downloading stuff, I'm restarting jobs

@larsoner
Copy link
Member

mne/gui/_coreg.py:43 in public class `CoregistrationUI`:
        D204: 1 blank line required after class docstring (found 0)

@hoechenberger
Copy link
Member Author

D204: 1 blank line required after class docstring (found 0)

Urgh, I specifically REMOVED the blank line there … sigh

@larsoner larsoner merged commit abf530f into mne-tools:main Jan 26, 2022
@larsoner
Copy link
Member

Thanks @hoechenberger !

@hoechenberger hoechenberger deleted the hoechenberger/issue10227 branch January 26, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieving Coregistration from CoregistrationUI
2 participants