Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_data_frame API change #10925

Merged
merged 3 commits into from Jul 13, 2022
Merged

to_data_frame API change #10925

merged 3 commits into from Jul 13, 2022

Conversation

drammock
Copy link
Member

we said we'd make this API change for 0.23 but it never happened.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 for merge assuming CIs are happy other than what will be fixed by #10923

@drammock drammock merged commit febd798 into mne-tools:main Jul 13, 2022
@drammock drammock deleted the df-deprecation branch July 13, 2022 22:21
larsoner added a commit to alexrockhill/mne-python that referenced this pull request Jul 14, 2022
* upstream/main:
  to_data_frame API change (mne-tools#10925)
  MAINT: Fix Qt issue (mne-tools#10923)
  Update inverse.rst DOC (mne-tools#10922)
  DOC: Clean up Forward and SourceSpaces (mne-tools#10911)
  [MAINT, MRG] Move sensor cluster permutation example to correct directory (mne-tools#10917)
  [MRG] Add data loader functions for BESA files (mne-tools#10892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants