[FIX] Bug loading projections in CSD h5 files. #11072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Aug 23, 2022
drammock
approved these changes
Aug 23, 2022
cgohil8
force-pushed
the
csd_projections
branch
from
a61e4b8
to
7d06622
Compare
drammock
reviewed
Aug 23, 2022
Co-authored-by: Daniel McCloy <dan@mccloy.info>
agramfort
reviewed
Aug 23, 2022
cgohil8
force-pushed
the
csd_projections
branch
from
c7db25a
to
03b09b3
Compare
check this locally in the terminal from root of repo with |
Yep, just saw this. I overwrote the commit. Should hopefully be fine now. |
|
Marking for auto-merge, thanks in advance @cgohil8 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10757.
Fixes the mne.time_frequency.csd.CrossSpectralDensity returned by mne.time_frequency.read_csd. Previously the CrossSpectralDensity object's projs attribute was a list of dict now it's a list of mne.proj.Projection.