New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add webp support to Report #11359
Conversation
kwargs['pil_kwargs'] = dict(optimize=True, compress_level=9) | ||
pil_kwargs.update(optimize=True, compress_level=9) | ||
if pil_kwargs: | ||
# matplotlib modifies the passed dict, which is a bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened matplotlib/matplotlib#24657 but in practice we won't ever really need to remove this line since it'll be very quick
Okay this PR now also:
Ready for review/merge from my end @drammock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look good. +1 for merge assuming the doc rendering looks right and CIs are green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
CircleCI looks good, Azure is just a timeout, and using this PR's new default format |
* upstream/main: ENH: Add webp support to Report (mne-tools#11359) ENH: More complete report repr (mne-tools#11357) MAINT: Simplify server installation instructions (mne-tools#11356) BUG: Fix where report replacement did not respect section (mne-tools#11346) [DOC] Fix video link for coregistration (mne-tools#11354)
* upstream/main: ENH: Add webp support to Report (mne-tools#11359) ENH: More complete report repr (mne-tools#11357) MAINT: Simplify server installation instructions (mne-tools#11356) BUG: Fix where report replacement did not respect section (mne-tools#11346) [DOC] Fix video link for coregistration (mne-tools#11354) Revert "[ENH] Add tutorial on time-frequency source estimation with STC viewer GUI" (mne-tools#11350)
Saves ~50% in mne-bids-pipeline
Closes #11358
Closes mne-tools/mne-bids-pipeline#682