Remove legacy plot_psd* funcs/methods in our docs and codebase #11563
Conversation
mne/report/report.py
Outdated
| fig = raw.plot_psd(fmax=fmax, show=False, **add_psd) | ||
| fig = raw.compute_psd(fmax=fmax, **add_psd).plot(show=False, ) |
There was a problem hiding this comment.
The kwargs used to be passed to plot_psd, now are passed to spectrum.plot(). Needs a deprecation cycle?
I'd say it's not worth it here given that the arguments are so similar. However, I do think you need to triage them, e.g., tmin/tmin/fmin/fmax need to go to compute_psd and plotting ones need to go to .plot. I don't think we want to remove any of these options, as people could reasonably want to just compute the PSD for the first 60 seconds for example, and say whether or not to plot in dB or whatever -- and these need to now go to two different methods.
There was a problem hiding this comment.
if we're going to triage then yeah, no need to deprecate. I'll pull out the triaging from the ToSpectrumMixin into a helper func so we can reuse it here.
|
I've compared all the spectrum plots in the edited examples/tutorials against the corresponding plots in our dev docs, and they all look unchanged. This is ready for review. |
* upstream/main: Fix bug in new `mne.sys_info()` (mne-tools#11577) Remove legacy plot_psd* funcs/methods in our docs and codebase (mne-tools#11563) The order of raw1.info["bads"] should not matter when concatenating with raw0.info["bads"] mne-tools#11501 (mne-tools#11502) MAINT: Fixes for matplotlib and pandas (mne-tools#11574) Fix Circle [circle deploy] Fix export to EDF format with a set physical range smaller than the data range (mne-tools#11569) Slightly rework `mne.sys_info()` (mne-tools#11568)
closes #11554
@larsoner WDYT about the changes to Report in 9b481b7? The kwargs used to be passed to plot_psd, now are passed to spectrum.plot(). Needs a deprecation cycle?