Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG?: KIT coils have units FIFF_UNIT_T, not FIFF_UNIT_T_M #2711

Closed
larsoner opened this issue Dec 16, 2015 · 7 comments
Closed

BUG?: KIT coils have units FIFF_UNIT_T, not FIFF_UNIT_T_M #2711

larsoner opened this issue Dec 16, 2015 · 7 comments

Comments

@larsoner
Copy link
Member

The unit for all channels, including FIFFV_COIL_KIT_GRAD channels (and FIFFV_COIL_KIT_REF_MAG, which makes sense), is FIFF_UNIT_T. Is this a typo? It seems like KIT grads should have units FIFF_UNIT_T_M. Not having the correct units is making the picking functions think they're magnetometers, and thus breaking Maxwell filtering, which needs to distinguish between grad and mag to exclude external components. I can make the change in the KIT code, but then it won't match what MNE-C's conversion routines give. @mshamalainen @teonlamont any ideas?

@larsoner
Copy link
Member Author

From reading a bit about KIT sensors, they do talk about converting the data to Tesla units (not Tesla / m), so it seems correct. But the channels behave like gradiometers according to Maxwell filtering (first degree external components are noisy around zero). I'd still like to hear if you think UNIT_T is the right unit, but now I'm also curious that, if it is, should doing pick_types(meg='grad') also return these channels? I think it probably should, even if the units don't match other grad channels...

@larsoner
Copy link
Member Author

Scratch that, I was reading about CTF sensors...

@agramfort
Copy link
Member

agramfort commented Dec 16, 2015 via email

@kingjr
Copy link
Member

kingjr commented Dec 16, 2015

The second gradiometers

"magnetometers".

I learnt my lesson :)

Close..

@larsoner
Copy link
Member Author

larsoner commented Dec 16, 2015 via email

@agramfort
Copy link
Member

agramfort commented Dec 16, 2015 via email

@larsoner
Copy link
Member Author

Thanks @agramfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants