Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIT data doesn't retain MAG/GRAD type for channels #5311

Closed
monkeyman192 opened this issue Jul 2, 2018 · 5 comments
Closed

KIT data doesn't retain MAG/GRAD type for channels #5311

monkeyman192 opened this issue Jul 2, 2018 · 5 comments

Comments

@monkeyman192
Copy link
Contributor

When importing KIT data we noticed that although the channel type is correct in the channel data (6001 for KIT data: FIFF.FIFFV_COIL_KIT_GRAD (we have gradiometers)), when observing the info of the raw we get chs : list | 193 items (MAG: 125, MISC: 67, STIM: 1)
Looking through the reason for this, it is because both MAG and GRAD type sensors are given FIFF.FIFF_UNIT_T as their unit, but when the channel type is determine by pick.py, the GRAD channel type has the FIFF.FIFF_UNIT_T_M type, so KIT data will never be realised to be a GRAD channel.
It is simple to add a few lines in the kit.py file to check whether the channel type is a gradiometer or magnetometer and set the units appropriately.
If this seems reasonable I can make a PR with the changes (unless there is a better way?)

@agramfort
Copy link
Member

@monkeyman192 : axial gradiometers like CTF with systems are considered by MNE as magnetometers on purpose. It's because they produce data that are much closer to a magnetometer as to a planer gradiometers in a vectorview system.

does it help?

@monkeyman192
Copy link
Contributor Author

Ah, ok, I see.
This still leaves an issue that when being used in conjunction with mne-bids the channel type in the channel tsv is listed as a magnetometer channel, whereas it should be listed as an axial gradiometer. This can probably be fixed on the mne-bids end though by being a bit more thorough when checking the channel type...

@agramfort
Copy link
Member

agramfort commented Jul 3, 2018 via email

@jasmainak
Copy link
Member

yes, please let's discuss on mne-bids

@larsoner
Copy link
Member

larsoner commented Jul 5, 2018

Closing as non-MNE issue but feel free to reopen if there is something we need to do here

@larsoner larsoner closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants