New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meas_date documentation inconsistency #5432
Comments
I think after I/O round trip it is always 2 ints. We probably need to improve our raw readers to make it more consistent. We could add a test to
I guess you could make it an |
yes we need more consistency in the raw data readers.
regarding the floating functions I prefer these when private as users don't
get exposed
to them with using tab completion. End users should not see these functions.
|
@agramfort I'm not sure I fully follow your thought here. |
_handle_meas_date cannot be discovered with tab so easily. Whereas if I have a method in Annotations I just use tab in an instance of annotations and I start seeing a bunch of private functions I should not see. Clear? |
I think this is fixed |
In
mne.Info
,meas_date
is a list of two ints.mne-python/mne/io/meas_info.py
Line 149 in ff8ebca
however, based on
_handle_meas_date
,raw.info['meas_date']
can have other formats.mne-python/mne/annotations.py
Lines 272 to 281 in ff8ebca
(Also, I find
_handle_meas_date
naming confusing, plus I don't understand why is a free function. IMHO it should be raw object method. i.e:raw.get_meas_date_in_absolute_seconds
but I don't have enough arguments to do a proper assessment)The text was updated successfully, but these errors were encountered: