Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Website update options #8184

Closed
larsoner opened this issue Sep 1, 2020 · 6 comments · Fixed by #8757
Closed

STY: Website update options #8184

larsoner opened this issue Sep 1, 2020 · 6 comments · Fixed by #8757

Comments

@larsoner
Copy link
Member

larsoner commented Sep 1, 2020

Something for someone to work on when they want a break from "doing science"

@larsoner
Copy link
Member Author

larsoner commented Sep 1, 2020

I played a little bit with each of these and neither is trivial

@drammock
Copy link
Member

drammock commented Sep 1, 2020

+1 for switching (after 0.21).

@sappelhoff
Copy link
Member

what are the reasons to switch the website style?

@drammock
Copy link
Member

drammock commented Sep 1, 2020

what are the reasons to switch the website style?

  1. the current theme doesn't support next/previous buttons on documentation pages by default.
  2. current theme has issues with default scroll alignment (target anchors are often just off the top edge of the screen, or at least obscured by the navigation bar / dev bar)
  3. current theme is one person's project, and is not being developed very actively (~1 year since last commit). Proposed new theme is used by Pandas, Bokeh, etc. and its last commit is yesterday, so I predict it to be maintained / upgraded for a long time.

Note that switching the theme doesn't necessarily mean that the site has to look drastically different. We can still customize the styling to make it look more or less like the current site does (in terms of color palette, typeface, layout, etc).

@larsoner
Copy link
Member Author

larsoner commented Sep 1, 2020

what are the reasons to switch the website style?

Note that switching the theme doesn't necessarily mean that the site has to look drastically different. We can still customize the styling to make it look more or less like the current site does (in terms of color palette, typeface, layout, etc).

To quote the Tim Hoffman on matplotlib gitter (not pinging his handle, doubt he cares about our decision process):

Overall it’s not too bad. There are some aspects I don’t like as well, but that’s also true for our current theme. Having a similar theme across a number of libraries can be a usability plus (with some color/font variations). From tge maintainer pov, the advantage is a carefully crafted (I think) modern theme. IMHO the builtin sphinx themes (From which ours is forked) are not really modern anymore, neither concerning design, or navigation/usability, or technically (e.g. responsiveness).

I more or less agree with this. So I would say some theme that's recognizable as being "in the scientific Python ecosystem" but (maybe) with some minor deviations to give it some MNE "flair" might be worth considering.

@larsoner
Copy link
Member Author

See also where mne-nirs and @rob-luke changed/is changing: mne-tools/mne-nirs#207, mne-tools/mne-nirs#208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants