Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plotting of events when there are overlapping epochs #9505

Merged
merged 8 commits into from Jun 25, 2021
Merged

Fix plotting of events when there are overlapping epochs #9505

merged 8 commits into from Jun 25, 2021

Conversation

drammock
Copy link
Member

closes #9502

cc @sappelhoff

@drammock drammock added the VIZ label Jun 24, 2021
sappelhoff
sappelhoff reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my real data and it works like a charm, everything is as expected now.

I think you forgot to set the warned variable though, because it's printing one info per plotted epoch, which is overkill. See my code suggestion.

Thanks!

mne/viz/epochs.py Show resolved Hide resolved
@drammock @sappelhoff
warn once
f153740 
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
drammock
drammock commented Jun 25, 2021
View reviewed changes
mne/viz/epochs.py Outdated Show resolved Hide resolved
@drammock
Copy link
Member Author

all green, ready for review/merge @agramfort @larsoner

@agramfort agramfort merged commit 3078533 into mne-tools:main Jun 25, 2021
@drammock drammock deleted the fix-overlap-epo-event-plot branch June 25, 2021 17:41
@agramfort
Copy link
Member

Thx @drammock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff left review comments

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
VIZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plotting overlapping epochs: Events not properly aligned in plot?
3 participants
@drammock @agramfort @sappelhoff