Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, ENH: Add cortex, fix sensors #9750

Merged
merged 3 commits into from Sep 16, 2021
Merged

MRG, ENH: Add cortex, fix sensors #9750

merged 3 commits into from Sep 16, 2021

Conversation

larsoner
Copy link
Member

Closes #9744

  1. Fixes bug introduced in [ENH, MRG] Add mne.viz.Brain.plot_sensors and refactor mne.viz.plot_alignment #9585 (cc @alexrockhill) where fNIRS and projected EEG sensors were not scaled properly based on units

  2. Fixes a bug where we iterated over some views twice (in the case of hemi='both') when we should have just done it once -- this is fixed by iterating over 'vol' as the hemi

  3. Adds support for custom cortex color mappings in mne.viz.Brain, which is something I've wanted for a while and was necessary to restore this image from stable while still using mne.viz.Brain instead of plot_alignment:

  4. Streamlines the iteration over views by calling .subplot inside _iter_views rather than doing it manually each time (cc @GuillaumeFavelier )

@larsoner
Copy link
Member Author

@rob-luke render fixed:

@larsoner larsoner merged commit aea40ff into mne-tools:main Sep 16, 2021
@larsoner larsoner deleted the sensors branch September 16, 2021 20:53
@alexrockhill
Copy link
Contributor

Thanks for cleaning this up @larsoner

@rob-luke
Copy link
Member

Brilliant, thanks @larsoner very neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot sensors is broken, not showing sensors in rendered docs.
4 participants