MRG: Add "interaction" param to CoregistrationUI #9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure seems unrelated: |
|
trying : @hoechenberger can you have a look? it seems there was some interaction option with mayavi backend. |
Oh, I never tried the CLI. Yes, I can fix that. |
|
@agramfort Can you see if the last commit fixes things for you? |
hoechenberger
commented
Nov 8, 2021
hoechenberger
changed the title
larsoner
approved these changes
Nov 8, 2021
|
@GuillaumeFavelier feel free to merge if you're happy. pip-pre can be ignored and should be fixed by #9973 |
|
Going ahead and merging as Guillaume is on vacation |
|
@larsoner Is it safe to backport this? |
|
Also made me realize I forgot a changelog entry. |
|
I think we can consider it a bugfix, don't forget to add an entry in the |
|
... also when backporting, please add a line to |
hoechenberger
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Nov 8, 2021
hoechenberger
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Nov 8, 2021
Merged
agramfort
pushed a commit
that referenced
this pull request
Nov 8, 2021
larsoner
added a commit
to drammock/mne-python
that referenced
this pull request
Nov 8, 2021
* upstream/main: remove dead link (no suitable alternative) [skip actions][skip azp] (mne-tools#9979) MRG: Improve docstring of mne.io.Info and improve error messages in Info._attributes (mne-tools#9922) MRG: Add "interaction" param to CoregistrationUI (mne-tools#9972) MRG, FIX: Fix interior check (mne-tools#9968)
larsoner
added a commit
that referenced
this pull request
Nov 9, 2021
* Backport #9972 * Fix defaults * MRG: Add argument overwrite to export for raws and epochs to match save. (#9975) * Add argument overwrite to export for Raws. * Add argument overwrite to export for epochs. * Add tests. * Add entry to changelog. * Move entry to changelog to Bugs and fix spelling typo. * fix indentation for ..versionadded * typo fix. * fix tests. * Change versionadded from 1.0 to 0.24.1 [skip azp] [skip actions] * Add overwrite for evoked instances (mffpy related). * FIX: replace else statement with finally. * Use shutil.rmtree instead of os.remove since mffpy creates a directory. * Remove finally. * Update changelog. * improve comment preceding folder deletion. * Update mne/epochs.py [skip ci] Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Update mne/export/_egimff.py [skip ci] Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Update mne/export/_export.py [skip ci] Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Update mne/export/_export.py [skip ci] Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Update mne/export/_export.py [skip ci] Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Update mne/export/_egimff.py Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * Fix behavior when pathlib.Path are passed instead of strings. * Fix import and style. * add test for epochs as well. * Remove str(fname) as it's not needed. * fix positional/keyword arguments. Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * remove dead link (no suitable alternative) [skip actions][skip azp] (#9979) * FIX: Backport fix * import fix for scipy 1.8 pre (#9973) * import fix for scipy 1.8 pre * fix arg oversight * FIX: A couple more * FIX: Found another * FIX: More [skip azp] [skip circle] * FIX: Correct [skip circle] [skip azp] * FIX: One more Co-authored-by: Eric Larson <larson.eric.d@gmail.com> Co-authored-by: Mathieu Scheltienne <73893616+mscheltienne@users.noreply.github.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com> Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
interactionkwarg toCoregistrationUI.mne.gui.coregistration()inmainsimply ignores itsinteractionparameter and doesn't pass it toCoregistrationUI. This PR fixes this behavior.Following a recent conversation with @larsoner, this also changes the default interaction style to
'terrain'.In the
'terrain'interaction mode, zooming by scrolling up/down with the mouse doesn't work for me on macOS, so this needs to be fixed.Screen.Recording.2021-11-06.at.19.51.47.mov
Screen.Recording.2021-11-06.at.19.52.56.mov
cc @agramfort