Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why convert country name to uppercase? #1

Closed
thetutlage opened this issue Jul 14, 2016 · 2 comments
Closed

Why convert country name to uppercase? #1

thetutlage opened this issue Jul 14, 2016 · 2 comments
Labels
Milestone

Comments

@thetutlage
Copy link

Is there any specific reason to return country names in uppercase. When I fetch the list of countries from https://github.com/mnowik/ember-countries/blob/master/addon/utils/countries-lists.js, they are in format that they supposed to be in.

Whereas, when I am trying to get the name of the country from it's ISO code using this method https://github.com/mnowik/ember-countries/blob/master/addon/utils/country-properties.js#L7, it returns the name back but transforms it to uppercase, which is not a consitent behavior.

Let me know if required, I can submit a PR for same

@thetutlage thetutlage changed the title Why convert countries to upperCase Why convert country name to uppercase? Jul 14, 2016
@mnowik
Copy link
Owner

mnowik commented Jul 21, 2016

@thetutlage Thanks for the heads up! You are right, the behavior is not consistent.
If you have time for a PR it would be perfect.

Cheers

@mnowik mnowik added this to the bugs milestone Aug 23, 2016
@mnowik mnowik added the bug label Mar 28, 2017
@mnowik
Copy link
Owner

mnowik commented Apr 6, 2017

@thetutlage Sorry for the delay. I update this package and change a lot of methods. I am going to close this issue. If you think that it needs to be re-open, feel free to ping me.
Cheers

@mnowik mnowik closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants