Some customizations #4
Conversation
…essIndicator.adaptive
| @@ -28,6 +28,11 @@ class _BaseFormField<T> extends StatefulWidget { | |||
| final FocusNode? focusNode; | |||
| final bool expands; | |||
| final Function(FormFieldState<T> field) onRemove; | |||
| final Icon locationIcon; | |||
There was a problem hiding this comment.
create a class holds the new properties MapViewConfig
and add these new props in OpenMapSettings so that it can be configured globally
There was a problem hiding this comment.
I think that properties that refer to the map style should not go in the global configuration, because it is possible that you want to have two maps with different styles in the same app
There was a problem hiding this comment.
I think would be a good idea encapsulating everything in a map style class (something like MapViewConfig). This would give the possibility of having multiple styles.
There was a problem hiding this comment.
you can use OpenMapSettings multiple times the package inherit from the nearest one in the widget tree
There was a problem hiding this comment.
In this case it's ok.
| @@ -119,6 +129,7 @@ class __BaseFormFieldState<T> extends State<_BaseFormField<T>> { | |||
| : effectiveDecoration.suffixIcon); | |||
|
|
|||
| return InkWell( | |||
| borderRadius: widget.borderRadius, | |||
There was a problem hiding this comment.
if this for clipping may be use ClipPath is best fit as the input border may not be totally round or has a custom shape
ClipPath(
clipper: ShapeBorderClipper(effectiveDecoration.border),
);
lib/src/map_app_bar.dart
Outdated
| @@ -130,7 +134,7 @@ class _MapAppBarState extends State<MapAppBar> { | |||
|
|
|||
| return AppBar( | |||
| leading: state.mapOrNull( | |||
| searching: (_) => const Center(child: CupertinoActivityIndicator()), | |||
| searching: (_) => const Center(child: CircularProgressIndicator.adaptive()), | |||
There was a problem hiding this comment.
making this customizable will be good
|
I'm waiting for you to make your changes if you can't let me know to merge |
I'm sorry I've been very busy these days and I haven't had time. As soon as I have a chance I'll do another PR |
Added some customizations parameters.