This repository has been archived by the owner on May 12, 2023. It is now read-only.
Fix the release ci process #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moaazsidat I would add you as a reviewer, but don't seem to be able to add any to this PR for some reason. |
|
馃帀 This PR is included in version 1.5.5 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous three commits have not been deployed to npm, and this seems to be due to the
deployGitHub action failing on thesemantic-releasestep (https://github.com/moaazsidat/react-native-qrcode-scanner/runs/4049234410?check_suite_focus=true)This PR changes the required node version to 14, which should fix the issue that
semantic-releaseis failing on ([semantic-release]: node version >=14.17 is required. Found v12.22.7.I haven't been able to test the deploy process using node 14, so I'm not sure if there are any new issues created by this node version change.
I'm hopeful that it will allow the previous commits to be deployed to npm though 馃