Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file name problem on windows #45

Merged
merged 1 commit into from Jan 4, 2022
Merged

Fix file name problem on windows #45

merged 1 commit into from Jan 4, 2022

Conversation

Aminujb
Copy link
Contributor

@Aminujb Aminujb commented Dec 20, 2021

Hello, I encountered a problem when I forked the project and tried to clone on my WINDOWS OS:
image

I suspected this problem was WINDOWS specific, so I switched to Ubuntu and tested the cloning and it worked well without errors
image

So I decided to try a change of name of the file that git was having issues with on WINDOWS. Apparently the question mark in the file name "8-preparing-for-CKA-CKAD?" is not WINDOWS friendly. I removed just the question mark and retested cloning my fork version and voila the problem disappeared.

image

It may be a small fix but it impedes contributions of WINDOWS based users. I'll suggest that the Contribution Policy should also reflect this kind of situation to avoid a repetition in the future.

Regards.

@moabukar moabukar merged commit 1bf2e9e into moabukar:main Jan 4, 2022
@moabukar
Copy link
Owner

moabukar commented Jan 4, 2022

Amazing, thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants