UIEffect & UIHsvModifier & UITransitionEffect Strange action

[jzgenius]

Describe the bug
Hi,
First of all, thank you for developing such helpful package.
And,
On Editor, single UI component + UIEffect components.
set effect value after, play, stop, the value not change, but effect strange changed.
please watch gif.

To Reproduce
Steps to reproduce the behavior:

1. single UI component + UIEffect component.
2. UIEffect & UIHsvModifier & UITransitionEffect all has this issue.

Environment (please complete the following information):

• Platform: MacBook Pro 2018, macOS 10.14.2
• Platform: Microsoft Surface Book2
• Unity: 2018.3.0f2
• UIEffect: v3.0.1 & develop Branch.

Additional context
If you fix these issues, please mail me how to fix. Thanks!

[mob-sakai]

Hi @jzgenius
Thank you for reporting!

[mob-sakai]

It was very easy to understand thanks to your plain explanation. :)

[jzgenius]

hi, Is there a quick way to fix this issue?

[mob-sakai]

Call SetDirty on play mode changed.
That's all I can come up with at the moment.
I don't have my pc on hand now, so I'll try it later.

[jzgenius]

Waiting for your good news and thank you for your reply.

[mob-sakai]

@jzgenius, I have a good news for you.
I found a way to fix this issue! :)

[jzgenius]

hi,
That's great! profession! Efficient!
Can you tell me how to solve it.
^&^

[mob-sakai]

[mob-sakai]

I made a very simple mistake: I forgot to initialize the dirty flag when parameter texture is generated.

ParameterTexture.cs (line 168)

if (!_texture)
{
	_texture = new Texture2D(_channels / 4, _instanceLimit, TextureFormat.RGBA32, false, false);
	_texture.filterMode = FilterMode.Point;
	_texture.wrapMode = TextureWrapMode.Clamp;

	updates.Add(UpdateParameterTexture);
	_needUpload = true; // <<<< Need this line!
}

[jzgenius]

Understood, learned.
Thank you again for your work.
Best Regard!