Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Performance of script #1

Closed
mobeigi opened this issue Jul 21, 2019 · 1 comment
Closed

Improve Performance of script #1

mobeigi opened this issue Jul 21, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@mobeigi
Copy link
Owner

mobeigi commented Jul 21, 2019

Example run with account with 581 friends (but only processing 386 with linked Facebook birthday).

[Running] python3 -u "F:\Google Drive\Git\Github\mobeigi\fb2cal\src\fb2cal.py"

[Done] exited with code=0 in 158.374 second

Need to profile script and make improvements.
Unfortunately need to make request per friend which seems to be the bulk of the processing time.
@mobeigi mobeigi added the enhancement New feature or request label Jul 21, 2019
@mobeigi mobeigi changed the title Slow Performance Improve Performance of script Jul 26, 2019
@mobeigi mobeigi added this to the 1.1.0 milestone Jul 27, 2019
@mobeigi
Copy link
Owner Author

mobeigi commented May 17, 2020

Fixed by #65. As expensive composer query lookups are no longer used at all, the script will finish in a few seconds (only needing to query the ajax endpoints 12 times in total, once for each month).

@mobeigi mobeigi closed this as completed May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@mobeigi