Subclass the shell packets by STDOUT/STDIN/ERR #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @SalvatoreT! 🎉 Just a couple comments for you to address and then I'll merge this in and deploy a release! |
Making the packets an explicit class type makes it easier to use a `when` statement and handle the use cases. Using an int type means that a consumer would have to use an `else` statement, even though the ID types have already been checked.
SalvatoreT
force-pushed
the
salvatoret/type-shell-packets
branch
from
ab848ba
to
95217c5
Compare
Leland-Takamine
approved these changes
Aug 1, 2022
|
Version |
|
That was fast! Thanks for accepting the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the packets an explicit class type makes it easier to use a
whenstatement and handle the use cases. Using an int type means that a consumer would have to use anelsestatement, even though the ID types have already been checked.