Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh error messages appear out of order #52

Closed
ahroach opened this issue Mar 11, 2012 · 2 comments
Closed

ssh error messages appear out of order #52

ahroach opened this issue Mar 11, 2012 · 2 comments
Labels

Comments

@ahroach
Copy link
Contributor

ahroach commented Mar 11, 2012

Some error messages from the initial ssh connection appear after the password prompt is reprinted. For example, when inputting an incorrect password:

aroach@champignon:~$ mosh champignon
aroach@champignon's password:
aroach@champignon's password: Permission denied, please try again.

@keithw
Copy link
Member

keithw commented Mar 12, 2012

Hmm, the problem here is that we are being sloppy and allowing SSH's controlling terminal to be the user's /dev/tty (not the pty). That way SSH gets input from the keyboard (e.g. the password) without our having to ferry the keystrokes to SSH. Unfortunately it also means when SSH writes directly to the tty (as it does for the password prompt, but not "Permission denied"), we never get it and it just goes straight to the terminal.

Fixing this would take some more sophistication: we would need a poll loop to ferry keystrokes to SSH and then SSH's output to the terminal, except we'd probably want to screen out the "MOSH IP" line, which is trickier when we are going byte-by-byte.

I'm inclined to leave this as-is for now, at least for 1.0.

@achernya
Copy link
Collaborator

This was filed nearly 10 years ago, and we've had lots of changes to the mosh startup script since. It's unclear to me this issue still exists. Please reopen if you can reproduce with mosh 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants