Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True color escape sequences are even more complicated #951

Open
cgull opened this issue Dec 25, 2017 · 1 comment
Open

True color escape sequences are even more complicated #951

cgull opened this issue Dec 25, 2017 · 1 comment

Comments

@cgull
Copy link
Member

cgull commented Dec 25, 2017

It's recently been discovered that everybody's been implementing true-color escape sequences with colons wrong, it seems.

People have been implementing ESC [38:2:0:255:0m, but it should apparently be ESC [38:2:<colorspace>:0:255:0m, according to https://bugzilla.gnome.org/show_bug.cgi?id=791456 and https://gitlab.com/gnachman/iterm2/issues/6377. libvte and iTerm2 have both added support for this new, correct variant.

Currently this is an academic point because Mosh only implements the semicolon variant, and I don't think anybody has any desire to change that variant's behavior for compatibility reasons. But when we do parse the colon variant, we should probably handle the old, mistaken variant as well as this new variant.

Thanks to George Nachman's ITerm2 release notes for pointing this out and catching my eye.

@andersk
Copy link
Member

andersk commented Dec 25, 2017

Ha, https://en.wikipedia.org/w/index.php?title=ANSI_escape_code&diff=815749098&oldid=815051294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants