Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advisories-by-platform parsing (collateral) #64

Closed
6 tasks done
Tracked by #3309 ...
nick-mobilecoin opened this issue Apr 24, 2023 · 1 comment
Closed
6 tasks done
Tracked by #3309 ...

Advisories-by-platform parsing (collateral) #64

nick-mobilecoin opened this issue Apr 24, 2023 · 1 comment

Comments

@nick-mobilecoin
Copy link
Collaborator

nick-mobilecoin commented Apr 24, 2023

The advisories are provided in json format via https://api.portal.trustedservices.intel.com/documentation#pcs-tcb-info-v4

for example

curl "https://api.trustedservices.intel.com/sgx/certification/v4/tcb?fmspc=00906ED50000"

The TCB format is specified in https://api.portal.trustedservices.intel.com/documentation#pcs-tcb-info-model-v3

The signature is over the tcbinfo contents so need to strip off the {tcbinfo: from the string.

We will want a JSON parser that doesn't walk down past the initial tcbInfo when looking for the signature.

Think the signing key comes from the request can see the chain with curl -v

TCB Test cases

  • duplicate tcbInfo fields. Simulates a malicious actor appending another tcbInfo field to the json hoping the first tcbInfo get's verified
    {
      tcbInfo: {},
      signature: "",
      tcbInfo: {}
    }
         
  • tcbInfo doesn't contain valid json. Ensures the parser that is looking for the root signature field errors properly and verification does not happen
  • tcbInfo contains a signature field. Ensures that the root signature is used by the verification logic. Simulates a malicious actor nesting signed tcbInfo inside of the root tcbInfo

PRs

@nick-mobilecoin
Copy link
Collaborator Author

Done in linked PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant