FOG-408: Make ingest peer uri filtering based on responder id #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there a successful deployment with this revision? |
|
not yet |
eranrund
reviewed
Mar 17, 2021
This fixes a bug that exists today in fog ingest deployments. I thought this was only a minor issue because, it would wrongly add the peer listen uri to the list of peer uris, but then filter it out and not connect to it. But because the active server replicates its peer list onto the backups continuously, they will all end up with this uri in their list, and there is no configuration that will fix this. Additionally, a server won't be able to filter out it's own (real) URI that the peers have in their lists, because it doesn't filter by responder id before this commit.
cbeck88
force-pushed
the
fix_peer_list_handling
branch
from
b1b680a
to
36dac5d
Compare
sugargoat
approved these changes
Mar 17, 2021
jcape
approved these changes
Mar 17, 2021
|
no, i did not create the responder id API -- i made a ticket already to track making responder id infallible https://mobilecoin.atlassian.net/browse/MCC-2273 It sounds like we are broadly in agreement -- I think all that would have to happen to implement this ticket is,
|
eranrund
reviewed
Mar 18, 2021
| @@ -38,7 +38,7 @@ pub struct IngestConfig { | |||
| pub peer_listen_uri: IngestPeerUri, | |||
|
|
|||
| /// List of all peers in this cluster | |||
| #[structopt(long)] | |||
| #[structopt(long, use_delimiter = true)] | |||
There was a problem hiding this comment.
if you want to have it work like --peers igp://foo,igp://bar,igp://baz,igp://qaz you need to put use_delimter = true. Otherwise, when structopt sees a Vec, you must make it like --peers igp://foo --peers igp://baz --peers igp://qaz and that just seems harder to read
There was a problem hiding this comment.
here's the issue in structopt repo: TeXitoi/structopt#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that exists today in fog ingest deployments.
I thought this was only a minor issue because, it would wrongly
add the peer listen uri to the list of peer uris, but then filter
it out and not connect to it. But because the active server replicates
its peer list onto the backups continuously, they will all end up
with this uri in their list, and there is no configuration that will
fix this. Additionally, a server won't be able to filter out it's
own (real) URI that the peers have in their lists, because it doesn't
filter by responder id before this commit.