Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when sending reaction in groups #177

Closed
deepfates opened this issue Mar 24, 2022 · 3 comments
Closed

Unexpected behavior when sending reaction in groups #177

deepfates opened this issue Mar 24, 2022 · 3 comments

Comments

@deepfates
Copy link
Contributor

When using self.send_reaction in DMs, it seems to work normally. However, when in groups, only the target author can see the reaction that the bot puts on their post. This is not the behavior i experience as a user of Signal Android or Desktop. Not sure if this is a bug in the Signal class, or an rpc error, or something in the underlying signal-cli.

@technillogue
Copy link
Contributor

this seems like it might be a bug with signal-cli, we should test signal-cli sendReaction directly w/o jsonrpc

@technillogue
Copy link
Contributor

technillogue commented Apr 2, 2022

https://github.com/mobilecoinofficial/forest/blob/main/forest/core.py#L496

        cmd = rpc(
            "sendReaction",
            param_dict=react,
            emoji=emoji,
            recipient=target_msg.source,
        )

lol we only ever send it as a DM, clients just magically figure out what message it's actually reacting too...

@technillogue
Copy link
Contributor

should be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants