This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
Avoid setting values when equal #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yForEqualityBeforeAssignment. Moved it into the NSObject(Motis_Subclassing) category in the header.
|
Hello @samkaufman, thanks for the pull request. I like the idea of what you are doing. I'll check the code and merge the pull request later today (and release a new cocoa pod version). Cheers, |
|
@vilanovi Hope it helps! |
vilanovi
added a commit
that referenced
this pull request
Mar 11, 2015
Avoid setting values when equal
|
Hello @samkaufman , Just published to cocoa pods the new version of Motis 1.1.0 with your changes. I have, however, updated the name of your method to "mts_checkValueEqualityBeforeAssignmentForKey". Also, checkout the new feature of value mapping very useful for enums: Thanks, |
|
Fantastic. Thanks, @vilanovi. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it’s useful to avoid calling setters when the values are known to be equal. In particular, calling a setter on an NSManagedObject will flag that object as updated in the context, which will trigger a database write, even if
[newValue isEqual:oldValue].This adds an optional
-mts_checkValueOfKeyForEqualityBeforeAssignment:.