Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's a logical mistake in 'AnimationCounter.js' file! #25

Closed
mohsen89z opened this issue Jun 3, 2017 · 2 comments
Closed

There's a logical mistake in 'AnimationCounter.js' file! #25

mohsen89z opened this issue Jun 3, 2017 · 2 comments

Comments

@mohsen89z
Copy link

in 'requestAnimationFrame' and 'cancelAnimationFrame' functions, your if statement is wrong!
@mohsen89z
Copy link
Author

also when you're defining now variable,
you're checking if 'undefined' !== undefined which is true always! you need to put the second 'undefined' inside a quotation.

@georgeOsdDev georgeOsdDev mentioned this issue Jun 5, 2017
Merged
@georgeOsdDev
Copy link
Member

@mohsen89z
Thanks!
#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georgeOsdDev @mohsen89z