Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quaternion.c conform with pure numpy C-API style #2

Closed
moble opened this issue Dec 12, 2014 · 0 comments
Closed

Make quaternion.c conform with pure numpy C-API style #2

moble opened this issue Dec 12, 2014 · 0 comments

Comments

@moble
Copy link
Owner

moble commented Dec 12, 2014

From @moble on October 17, 2014 4:48

As demonstrated in, e.g., rational, it's considered good practice to define the member functions starting with

static NPY_INLINE 

to encourage the compiler to make various optimizations. This would only be applicable if the contents of that file are moved inside numpy_quaternion.c. Alternatively, I could use some macro for both, defining it to be inline if it's undefined at the top of quaternion.c, but defining it to be static NPY_INLINE just before including into numpy_quaternion.c.

Copied from original issue: moble/numpy_quaternion#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant