Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement isclose() for quaternion #47

Closed
szsdk opened this issue May 13, 2017 · 2 comments
Closed

Implement isclose() for quaternion #47

szsdk opened this issue May 13, 2017 · 2 comments

Comments

@szsdk
Copy link

szsdk commented May 13, 2017

I was wondering if it is possible to implement np.isclose() or np.allclose() for quaternion which would be useful (especially for my project LOL).
@moble
Copy link
Owner

moble commented May 13, 2017

As stated, this is really more of an issue for numpy; I can't fix numpy code. However, quaternion.allclose is implemented. I'm not opposed to implementing quaternion.isclose, but I don't have time for it right now.

@moble
Copy link
Owner

moble commented May 13, 2017

However, it should be easy for you to use quaternion.allclose to write your own quaternion.isclose function. Feel free to make a Pull Request.

@moble moble closed this as completed in 1f8ba56 May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moble @szsdk