Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedElements are not properly unregistered after AdapterList is disposed #1

Open
MaciejCiemiega opened this issue Apr 19, 2020 · 0 comments

Comments

@MaciejCiemiega
Copy link
Member

Causes issues in the following scenario:

  1. On first screen there is an AdapterList component with FROM element.
  2. User navigates to next screen, that has no SharedElement.
  3. User navigates to next screen that has a TO element.

Here the transition between FROM and TO would start because we still remember that FROM element from first screen. This is due to a bug in Compose that cause AdapterList to never invoke onDispose on list items, so FROM element would never know it disappeared.

https://issuetracker.google.com/issues/150174792
I'm not sure if any workaround can be implemented before it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant