Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types FROM and TO may be misleading #2

Open
MaciejCiemiega opened this issue Apr 19, 2020 · 1 comment
Open

Types FROM and TO may be misleading #2

MaciejCiemiega opened this issue Apr 19, 2020 · 1 comment

Comments

@MaciejCiemiega
Copy link
Member

The types names may be a bit misleading, because they can be used interchangeably.
It doesn't matter if first one if FROM or TO. They are only used to detect the "other" one from the pair.

Without it I have no idea how to detect that one element was on "previous" screen and second one is on "next" screen, because there is no concept of screens and transitions between them.
We cannot rely on things like position or hierarchy change. Not every hierarchy change is a "screen" change and that would make it transition from its old position to its new position (or old/new places in hierarchy).

Maybe a better idea would be to change it to something more generic like screen: String so one can specify values like:

  • "list" on one screen
  • "details" on second screen

For now I stayed with FROM and TO because it makes it super simple to choose one o two enum values.

@myxzlpltk
Copy link

myxzlpltk commented Jun 1, 2023

Yeah its true. Maybe if it use tag property just like hero widget it wil be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants