Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom sound for notification when timer is up #64

Closed
mrozbarry opened this issue Apr 25, 2020 · 4 comments
Closed

Set custom sound for notification when timer is up #64

mrozbarry opened this issue Apr 25, 2020 · 4 comments
Labels
enhancement New feature or request
Projects

Comments

@mrozbarry
Copy link
Collaborator

No description provided.

@mrozbarry mrozbarry created this issue from a note in Version 1 (To do) Apr 25, 2020
@mrozbarry mrozbarry added the enhancement New feature or request label Aug 16, 2020
@mrozbarry
Copy link
Collaborator Author

Will solve #90

@mrozbarry
Copy link
Collaborator Author

mrozbarry commented Aug 16, 2020

Some timer complete sound effects I'm thinking about

Any other suggestions? My only requirement is they need to be royalty free, and preferably available in mp3 (but I can convert them as long as it doesn't violate any licensing).

@rzijp
Copy link

rzijp commented Aug 16, 2020

All great suggestions, what about letting the user choose?

@mrozbarry
Copy link
Collaborator Author

mrozbarry commented Aug 16, 2020

what about letting the user choose

Just to go down this rabbit hole, here's the cascade of questions I have

  • dropdown/radio group from pre-selected group
    • Just add audio files to public directory, and give the user a list to pick from. Can bake in licensing information if necessary.
  • user can pick an audio file
    • Custom URL
      • Give the user a text field to set audio, and do initial test to be sure the url works
    • Local file
      • User has to pick file each page reload
        • Audio is local, no licensing issue
      • User has to upload file somewhere, which goes back to custom url
        • Any problems with licensing?
      • Client needs to serialize audio file into some form of local storage
        • Audio is local, no licensing issue

@mrozbarry mrozbarry moved this from To do to In progress in Version 1 Aug 16, 2020
@mrozbarry mrozbarry moved this from In progress to To do in Version 1 Aug 16, 2020
@mrozbarry mrozbarry moved this from To do to In beta in Version 1 Aug 17, 2020
Version 1 automation moved this from In beta to Done Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Version 1
  
Done
Development

No branches or pull requests

2 participants