Better assertAlive error (show name of invoked action or accessed field)

[Amareis]

Feature request

Is your feature request related to a problem? Please describe.
When actions are invoked at destoyed node, there is no action name in error description, which can be helpful for debug. Currently I should use breakpoint on error throwing inside mst code to see stacktrace and look at action name.

Describe the solution you'd like
Show action name in assertAlive error if possible, or, in general, name of accessed field.

Are you willing to (attempt) a PR?

• Yes
• No

[xaviergonz]

I think if we console log an error then it should show the full stack trace even on warning mode (like it does in error mode), would that be good enough?

[xaviergonz]

PR merged, an stacktrace will show in the console in warn mode in the next release

[Amareis]

I'm used error mode, but even with it stacktrace sometimes is not really informative.

[xaviergonz]

Ah, feel free to reopen the issue then if you think the new addition is not enough

[Amareis]

Simple example, I just cannot see full stacktrace at sentry and even actions, which i used as breadcrumbs, isn't very helpful. But if i'll see accessed property name, it be way more easier to debug this situation.

[xaviergonz]

Did you check in the actual browser console? It should show an arrow near the error line that allows you to see the full stack trace once expanded (at least in chrome)

[Amareis]

In browser stacktrace is available, of course. But there is situations, when in stacktrace there is no any my source files - for example, if you add some arrow function callback, which is reading some field from mst, stacktrace just don't showing any meaningful strings in stacktrace, because it contains only call string of this callback, but not define's string.

[xaviergonz]

I thought sentry could be configured to use source maps and browse stack traces.
Either way reopening.

[Amareis]

In our sentry sourcemaps are enabled, of course. But, as I said, even stacktraces isn't helpful sometimes, so name of acessed property should simplify debug in some cases.

[xaviergonz]

@Amareis would this pr fix your issue?
#1147

[Amareis]

Yeah, just that I needed! Big thanks for it.

[Amareis]

Error displays wrong action path. There is should be /.setData() path (this is action at tree root, which is replace whole subtree).

Error: [mobx-state-tree] You are trying to read or write to an object that is no longer part of a state tree. (Object type: 'Chat', Path upon death: '/data/chats/items/4cd66e4b-09be-4c21-8153-1fa37f69758b', Subpath: 'id', Action: '/data/chats/items/4cd66e4b-09be-4c21-8153-1fa37f69758b.setData()'). Either detach nodes first, or don't use objects after removing / replacing them in the

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.