Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UndoManager - startGroup not working corretly [mst-middlewares] #754

Closed
chemitaxis opened this issue Apr 4, 2018 · 0 comments · Fixed by #755
Closed

UndoManager - startGroup not working corretly [mst-middlewares] #754

chemitaxis opened this issue Apr 4, 2018 · 0 comments · Fixed by #755
Assignees
@robinfehr
Labels
bug Confirmed bug has PR A Pull Request to fix the issue is available

Comments

@chemitaxis
Copy link
Contributor

Hi, I have been speaking with @robinfehr and we have detected a bug with the startGroup.

the reverse patches aren't the reverse patches but the normal patches

https://github.com/mobxjs/mobx-state-tree/blob/master/packages/mst-middlewares/src/undo-manager.ts#L73

In this case, the UndoManager undo method is not working fine after this:

code

Thanks!!
@robinfehr robinfehr self-assigned this Apr 4, 2018
@robinfehr robinfehr added the bug Confirmed bug label Apr 4, 2018
@robinfehr robinfehr mentioned this issue Apr 4, 2018
Merged
@robinfehr robinfehr added the has PR A Pull Request to fix the issue is available label Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinfehr robinfehr

Labels
bug Confirmed bug has PR A Pull Request to fix the issue is available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix undoManager grouping for arrays etc. robinfehr/mobx-state-tree
2 participants
@chemitaxis @robinfehr