Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Official Support #1

Closed
kuitos opened this issue May 30, 2018 · 8 comments
Closed

Proposal for Official Support #1

kuitos opened this issue May 30, 2018 · 8 comments

Comments

@kuitos
Copy link
Member

kuitos commented May 30, 2018

Hi @mweststrate
Recently I built this library to combine mobx with vue through a simple api what like mobx-react does, now it released v1.0.0 and reached 100% code coverage already, could you please donate some time to make a review and check is it good enough to move to mobxjs organization?

@mweststrate
Copy link
Member

Looks good! Should be compatible out of the box immediately as well with MobX 5, which means that it will support direct manipulation of objects, arrays etc, which is all more cumbersome in Vue ;-)

Feel free to submit an organization move request. I'll add you as collaborator as well.

@mweststrate
Copy link
Member

How does this library relate to https://github.com/dwqs/vue-mobx? Should the efforts be combined?

@mweststrate
Copy link
Member

N.B. note that moving it to the organisation means that there is a commitment @kuitos to support it from your side? I don't think there are a lot of other experienced Vue users in collaborators team of MobXJS :).

@kuitos
Copy link
Member Author

kuitos commented Jun 5, 2018

@mweststrate vue-mobx was not maintained any more, see dwqs/vue-mobx#4 . The author recommended movue .
And, the author of movue had raised a question which just mobx-vue solved: nighca/movue#16 .

Both the libraries are inspired by vue-rx, which I think would weaken the mobx power(sorry to @nighca 😜), I will post a article to explain this these days.

note that moving it to the organisation means that there is a commitment @kuitos to support it from your side?

That challenge is what I want!

I don't think there are a lot of other experienced Vue users in collaborators team of MobXJS

Yes that is what I concerned, fortunately I had use mobx-vue in our production to earn experience.

@nighca
Copy link

nighca commented Jun 5, 2018

Great effort @kuitos! Let me know if I can offer help.

@kuitos
Copy link
Member Author

kuitos commented Jun 6, 2018

Firstly, recommend mobx-vue on movue haha.@nighca 😜

@nighca
Copy link

nighca commented Jun 6, 2018

@kuitos Sure. I introduced mobx-vue in README. :)
By the way, I've got some ideas about mobx-vue and will explain in another issue.

@kuitos
Copy link
Member Author

kuitos commented Jun 6, 2018

all right:ok_hand:

@kuitos kuitos closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants