-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to monorepo #29
Comments
I can potentially help for the flutter sides if needed. 😄 |
Awesome @rrousselGit. I think this will speed up the move to monorepo as well. Ideally this code should live in the 🤔 One other option is you can create the hooks code in a separate folder to get started. Once you have it working, we can extract it out to |
I can try to tackle this after work. |
the issue with mono_repo is that is doesn't support flutter yet. I made a PR so that it won't crash, but it doesn't automatically download the Flutter sdk and run commands. This is still doable by using |
@pavanpodila I've tried various approaches to make a mono repo, but either I can't get them to work, or they seem to bring more complexity than they're worth. I say we create separate repositories for the packages for now, and see about a monorepo later. |
Do we even need separate repositories ? I suggest we keep the packages together under this repo and publish separately? I think maintenance is much easier if they are all together. At least at this stage where the packages are still maturing. What say? |
And agree about skipping the whole |
You are of course right about the ease of maintenance from a cross-package point of view, but Travis configuration becomes a problem. With a single package repository the ready made configs of |
I would heavily suggest to send a mail to Flutter for this. Because the community has been small until now, Flutter team haven't really noticed the monorepository issue. |
I think in principle the monorepo idea is good, so we can keep the two packages ( Let's get flutter_mobx working for now removing any mono_repo boilerplate? I'll help out with the Also as @rrousselGit suggested, we should get in touch with Flutter to share our specific issue? @katis could you raise an issue detailing where you found problems ? |
On a separate note, @rrousselGit can you take a look at the PR (#34) to see if there are any obvious fixes? |
That PR is probably not that useful starting point atm., I made a bit of a mess of it |
I don't see anything special. Looks good :) |
This is done. |
This will house various packages and make it easy to maintain:
Core
Experimental
localhost
url that can be opened in Chrome to see the visualization. The visualization itself can be built with React 🤓. Think of this as the Observatory for MobX )The text was updated successfully, but these errors were encountered: