Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR to send the MobX example to Brian Egan's flutter-samples #83

Closed
pavanpodila opened this issue Feb 3, 2019 · 18 comments
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pavanpodila
Copy link
Member

Brian has a nice collection of example code for various state-management frameworks, all building TODOMVC. Let's submit one for MobX as well 馃.

@pavanpodila pavanpodila added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 3, 2019
@rrousselGit
Copy link
Collaborator

I'll soon work on one for flutter_hooks and another yet to be released project of mine.

At that time if nobody started it, I can do it for mobx too.

@rrousselGit
Copy link
Collaborator

I started something here

A good chunk of it is done already. Feel free to have a look! 馃槃

@pavanpodila
Copy link
Member Author

Awesome @rrousselGit. I think we should have a plain vanilla MobX as well along with MobX with Hooks version

@rrousselGit
Copy link
Collaborator

Sure. The changes shouldn't be too hard.
I'll make it when I have one that pass all tests

@brianegan
Copy link

Mobx is looking great -- happy to receive PRs :)

@pavanpodila
Copy link
Member Author

Mobx is looking great -- happy to receive PRs :)

Wow, what an encouraging comment to receive! I am sure one of us will pick it up ASAP!

@rrousselGit
Copy link
Collaborator

rrousselGit commented Feb 27, 2019

Sorry I have too many things going on right now. If anybody wants to, feel free to continue.
My work is available here: https://github.com/rrousselGit/flutter_architecture_samples/tree/mobx

Otherwise, I'll continue this as soon as I get a bit of time to do so.

@brianegan
Copy link

brianegan commented Feb 27, 2019

Truly, no stress or rush from my side! Whenever you all have the time. 鉂わ笍

@pavanpodila
Copy link
Member Author

pavanpodila commented Mar 26, 2019

@brianegan I have created the TODOMVC example with source code, accompanied with an article on mobx.pub. Can I make a README.md file and send in a PR? The README will link to the article and the source, which is inside mobx_examples.

@brianegan
Copy link

brianegan commented Mar 26, 2019

Heya @pavanpodila! For the Flutter Arch Samples, it would be best to if the app complied with the spec: https://github.com/brianegan/flutter_architecture_samples/blob/master/app_spec.md

IMO, it would be hard to compare what you've got with the other samples, since it does not include include several features: Persistence, Routing, Testing, etc. Basically, it'd be more of an "Apples to Oranges" comparison than an "Apples to Apples" comparison.

@pavanpodila
Copy link
Member Author

That does make sense @brianegan. I'll make one as per the spec. Thanks for the clarification!

@pavanpodila pavanpodila pinned this issue Jul 10, 2019
@pavanpodila
Copy link
Member Author

Work is underway here: https://github.com/pavanpodila/flutter_architecture_samples

@kush3107
Copy link
Contributor

kush3107 commented Aug 1, 2019

@pavanpodila I can help you with this flutter architecture example.

@pavanpodila
Copy link
Member Author

Why don't you pick up from this repo, where I've made a sizeable set of changes: https://github.com/pavanpodila/flutter_architecture_samples. You can fork and send me a PR on that. All the code is in the mobx folder

@kush3107
Copy link
Contributor

kush3107 commented Aug 1, 2019

Ok thanks I will do that.

@andesappal
Copy link

Hey could @brianegan 's project also list the pros, cons, and best use cases for each option?

@MaikuB
Copy link
Collaborator

MaikuB commented Jan 9, 2020

@pavanpodila it got merged recently so I believe we can close this now right?

@pavanpodila
Copy link
Member Author

@pavanpodila pavanpodila unpinned this issue Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants