Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mobx-undecorate] Removes not mobx decorators #2558

Closed
pustovalov opened this issue Oct 25, 2020 · 2 comments · Fixed by #2590
Closed

[mobx-undecorate] Removes not mobx decorators #2558

pustovalov opened this issue Oct 25, 2020 · 2 comments · Fixed by #2590
Labels
🎁 mobx-undecorate Issue or PR related to mobx-undecorate package

Comments

@pustovalov
Copy link
Contributor

Code:

@withRouter
@observer
export class Component extends React.PureComponent {

Intended outcome:

export const Component = withRouter(observer(class Component extends React.PureComponent {}))

or throw an error

Actual outcome:

at the moment silently changes the code to this

export const Component = observer(class Component extends React.PureComponent {})

How to reproduce the issue:

run npx mobx-undecorate

Versions

mobx-undecorate: 1.0.2

@danielkcz danielkcz added the 🎁 mobx-undecorate Issue or PR related to mobx-undecorate package label Oct 25, 2020
@danielkcz
Copy link
Contributor

It would be very helpful if you can contribute a PR with a failing test for this. It will be much easier to fix without breaking anything else.

@mweststrate
Copy link
Member

Released as mobx-undecorate@1.0.3

@github-actions github-actions bot mentioned this issue Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 mobx-undecorate Issue or PR related to mobx-undecorate package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants