Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release #3601

Merged
merged 1 commit into from Feb 9, 2023
Merged

Next release #3601

merged 1 commit into from Feb 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 7, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

mobx@6.8.0

Minor Changes

  • fed3ff14 #3608 Thanks @emereum! - Do not expose the methods observe_ or intercept_ on computed values and observable values.

Patch Changes

mobx-undecorate@1.3.0

Minor Changes

Patch Changes

mobx-react-lite@3.4.1

Patch Changes

@github-actions github-actions bot force-pushed the changeset-release/main branch 6 times, most recently from 5051c70 to a6dc6c1 Compare January 12, 2023 14:11
@github-actions github-actions bot force-pushed the changeset-release/main branch 2 times, most recently from a4678e1 to 5aba160 Compare January 14, 2023 18:04
@github-actions github-actions bot force-pushed the changeset-release/main branch 2 times, most recently from 5f1bd0b to 0283828 Compare January 28, 2023 13:42
@urugator
Copy link
Collaborator

urugator commented Jan 28, 2023

Please do not merge, test fails with React 18.2.0 (we have 18.0.0 in main). Have to investigate if this is due to that refactor or if previous mobx-react-lite would be failing as well.

EDIT:
These tests (useAsObservableSource.deprecated.test.tsx,useLocalStore.deprecated.test.tsx) do fail even with previous impl (mobx-react-lite@3.4.0 + react@18.2.0), dunno why the behavior differs or if there is a solution (other than modifying tests). So probably safe to merge.
Interestingly useSyncExternalStore impl (#3590) doesn't seem to fail.

@github-actions github-actions bot force-pushed the changeset-release/main branch 8 times, most recently from bf2784f to 64f9655 Compare February 1, 2023 13:51
@urugator urugator merged commit faf075c into main Feb 9, 2023
@iChenLei iChenLei deleted the changeset-release/main branch February 10, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant