Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd: use lease instead of gc.root label #159

Closed
AkihiroSuda opened this issue Nov 13, 2017 · 3 comments · Fixed by #249
Closed

containerd: use lease instead of gc.root label #159

AkihiroSuda opened this issue Nov 13, 2017 · 3 comments · Fixed by #249
Assignees
@AkihiroSuda
Labels
area/containerd
Projects
2017Q4

Comments

@AkihiroSuda
Copy link
Member

Discussed in #155
@AkihiroSuda AkihiroSuda self-assigned this Nov 13, 2017
@AkihiroSuda AkihiroSuda added this to To Do in 2017Q4 Nov 13, 2017
@tonistiigi tonistiigi mentioned this issue Dec 7, 2017
Merged
@tonistiigi
Copy link
Member

tonistiigi commented Dec 8, 2017 •
edited

test failure/trace from #194 that should be gc related (in containerd worker) https://travis-ci.org/moby/buildkit/builds/313247704?utm_source=github_status&utm_medium=notification

edit: thought that link was permanent but it disappeared after rebuild

@tonistiigi
Copy link
Member

@AkihiroSuda Would you like me to look into this if you're busy with #176 ? Not 100% sure it is related but I've seen "snapshot not found" error couple of times now.

@AkihiroSuda
Copy link
Member Author

yes please and sorry for delay 😅

@tonistiigi tonistiigi mentioned this issue Dec 28, 2017
Merged
2017Q4 automation moved this from To Do to Done Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkihiroSuda AkihiroSuda

Labels
area/containerd
Projects
No open projects
2017Q4
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add prune support and fix containerd gc tonistiigi/buildkit
2 participants
@tonistiigi @AkihiroSuda