New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile2llb: support ADD git://
with git source op
#775
Comments
What git:// URL support do you mean? git context should work an use git source op. (although it doesn't seem to be implemented 100% correct yet moby/moby#38254) |
I meant |
ADD git://
with git source op
I don't think old builder supports it, right? This has not been added as a new feature. If you find it useful we can discuss it (and maybe use the experimental branch for it). Not sure I have an opinion myself atm. I think |
I don't personally have a use case for this, but OTOH, COPY vs ADD is already confusing enough. |
At some point the Some thoughts I've been playing with; COPY --from=git://... /some/file /somewhere
COPY --from=https://... /some/file /somewhere Last one may be tricky; what if the URL specified in Slightly off-topic, but another thing I was thinking about is to allow mounting remote sources: RUN --mount type=remote,src=git://...,dest=/somewhere
RUN --mount type=remote,src=https://...,dest=/somewhere The above would fetch the remote content, and mount it at RUN --mount type=remote,src=https://download.docker.com/linux/static/stable/x86_64/docker-18.09.0.tgz,dest=/temp/ \
tar -xzf /temp/docker-18.09.0.tgz --strip 1 -C /usr/local/bin docker/docker |
I like this! but how do you deal with auth? |
Good one; didn't really give that much thought yet |
If we have
The advantage is that you can now use |
For git we can do automatic ssh auth (like the ssh forwarding support for |
ohhhh wow |
True, but I do find that construct a bit confusing, as in; FROM scratch
ADD git://... / So that stage won't be a functional stage (unless |
Not sure what you mean by that. As there are millions of ways to have a nonfunctional stage if you use wrong commands. And nothing is stopping the user from making the files in git to be functional. Perhaps I was not clear that by having
|
@tonistiigi Is this intentionally left unimplemented?
The text was updated successfully, but these errors were encountered: