OSSpinlock is depreciated

[RnbWd]

Is this being used in Docker Mac Beta? I'm running macOS dev beta 3 - and somebody on the forums figured out that the ntpd daemon was causing the vm to hang (the normal behavior is for it to start normally, then after using the network for a few minutes - docker becomes unresponsive. Unloading ntpd - docker f works perfectly fine.

sudo launchctl unload/System/Library/LaunchDaemons/org.ntp.ntpd.plist

So I came here to investigate why this was happening. When I started to compile hyperkit, the build stopped and there was a warning that said something like

OSSpinLock is depreciated in version of macOs

Google searched it - found this article: http://engineering.postmates.com/Spinlocks-Considered-Harmful-On-iOS/

Apparently the command is considered harmful and causes networking issues for iOS and macOS - so in Sierra it's not even allowed to be compiled and potentially causing the hang - it's probably causing issues in all versions of OSX but in Sierra it's debilitating. Unless you killntpd.

So i went into the docs to find what they are replacing OSSpinLock with, and I found an undocumented command in os called os_unfair_lock https://developer.apple.com/reference/os/os_unfair_lock

So I started rewriting hacking on hyperkit (and parts of xhyve) to replace it. I've never actually attempted to program C (or even Objective C) - but just wanted to let ya'll know, and if I get it to compile locally - I'll submit a pull request.

I assume the new API would probably be the most efficient replacement - although there may be other ways around this that don't use unfair_lock - I assume that Apple intends that to be a replacement? But the docs don't say anything about it.

[RnbWd]

I was able to get hyperkit to compile with the new os API - tests pass - but there's an error in the build that indicates something else is also causing the issue with Sierra. Replacing ossspinlock might translate for all macOS - to Yosemite - but I don't know if the new kernel os methods are going to be supported - so at the moment it's just a modification for Sierra. But I'll email docker security just in case there's a security issue here that I'm not aware of.

[waittttting]

Can you tell me 'os_unfair_lock' in which header files？