Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestPoolHelper can loop forever if IPAM plugin lets it #1386

Closed
bboreham opened this issue Aug 10, 2016 · 1 comment
Closed

requestPoolHelper can loop forever if IPAM plugin lets it #1386

bboreham opened this issue Aug 10, 2016 · 1 comment

Comments

@bboreham
Copy link
Contributor

If I read it correctly, the expectation is that if FindAvailableNetwork indicates an overlap then requestPoolHelper can request another pool and the plugin will either return a different one or fail.

I have a plugin that does neither: it returns the same pool every time, because it is acting as glue to some pre-existing technology. Both Docker and the plugin spin rapidly, with Docker using a lot of CPU.

I think I can avoid getting into this situation by changing the way my plugin is called, but I might suggest putting a counter in requestPoolHelper to break the loop after some limit and tell the user what happened.

@GordonTheTurtle
Copy link

@bboreham It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

  • For a bug: do you still experience the issue with the latest version?
  • For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to #1926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants