Sort cluster nodes by node.name breaks UI with unassigned replicas

[mattijsf]

When ElasticSearch is running with one or more unassigned replicas the Cluster Overview page breaks with a javascript error:

Uncaught TypeError: Cannot read property 'name' of undefined 

Can be reproduced using ElasticSearch 0.19.8 with the following index:

$ curl -XPUT 'http://localhost:9200/twitter/' -d '{
    "settings" : {
        "number_of_shards" : 3,
        "number_of_replicas" : 2
    }
}'

[mattijsf]

I could fix this by making the following change inside /lib/es/widget.js:

b = second.cluster.name;into:
b = (typeof second.cluster !== "undefined") ? second.cluster.name : second.name;

[mattijsf]

Or maybe it is better to guarantee to have the unassigned clusters sorted on the bottom:

if ((typeof second.cluster === "undefined")) return 0;

[mobz]

preferably the order would be

• master node (at the top)
• data nodes (in alpha order)
• client nodes (in alpha order)
• unassigned ( if any )

I'm on holiday at the moment - would appreciate a patch!